telemetry: don't report ES client errors #4940
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
algorandskiy
previously approved these changes
Dec 23, 2022
Contributor
algorandskiy
left a comment
algorandskiy
left a comment
There was a problem hiding this comment.
please rebase on master where dns-related test failures are fixed
cce
force-pushed
the
ignore-es-errors
branch
from
9dbb74a to
e538f40
Compare
Contributor
Author
|
rebased! |
Codecov Report
@@ Coverage Diff @@
## master #4940 +/- ##
=======================================
Coverage 53.55% 53.56%
=======================================
Files 433 433
Lines 53864 53864
=======================================
+ Hits 28849 28850 +1
Misses 22768 22768
+ Partials 2247 2246 -1
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
algorandskiy
approved these changes
Dec 25, 2022
This was referenced Jan 23, 2023
This was referenced Jan 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Following on #4932 this also keeps ES client warnings and error logs from being reported back to telemetry.
Test Plan
Existing tests should pass.