ledger: move catchpoint related methods into a storage package #4835
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #4835 +/- ##
==========================================
- Coverage 53.80% 53.55% -0.26%
==========================================
Files 421 422 +1
Lines 53827 53830 +3
==========================================
- Hits 28963 28827 -136
- Misses 22516 22687 +171
+ Partials 2348 2316 -32
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
9 tasks
algorandskiy
approved these changes
Nov 29, 2022
Contributor
algorandskiy
left a comment
algorandskiy
left a comment
There was a problem hiding this comment.
Please fix two minor findings in the subsequent PR
| return | ||
| } | ||
|
|
||
| // LoadFullAccount converts baseAccountData into basics.AccountData and loads all resources as needed |
Contributor
There was a problem hiding this comment.
comment: baseAccountData -> BaseAccountData
Comment on lines
+406
to
+410
| if err != nil { | ||
| return | ||
| } | ||
|
|
||
| return |
algorandskiy
changed the title
accountdb.go into a store package (4 of N)
michaeldiamant
added a commit
to michaeldiamant/go-algorand
that referenced
this pull request
Nov 30, 2022
michaeldiamant
added a commit
that referenced
this pull request
Nov 30, 2022
This was referenced Nov 30, 2022
This was referenced Dec 5, 2022
This was referenced Dec 9, 2022
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Continue moving methods out of
accountdb.go.Previous parts of this refactor:
Test Plan
Existing tests.