Skip to content

Conversation

@michaeldiamant
Copy link
Contributor

Running unit tests on macOS results in several firewall-related accept/deny prompts asking: Do you want the application X to accept incoming network connections? The PR prevents these pop-ups by applying https://apple.stackexchange.com/a/405967 to affected tests.

@michaeldiamant michaeldiamant changed the title Squelch macOS accept incoming network connections notifications Tests: Squelch macOS accept incoming network connections notifications Nov 18, 2022
@codecov
Copy link

codecov bot commented Nov 18, 2022

Codecov Report

Merging #4814 (0c08992) into master (5b45539) will decrease coverage by 0.36%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #4814      +/-   ##
==========================================
- Coverage   54.62%   54.25%   -0.37%     
==========================================
  Files         417      417              
  Lines       53734    53734              
==========================================
- Hits        29351    29156     -195     
- Misses      21946    22142     +196     
+ Partials     2437     2436       -1     
Impacted Files Coverage Δ
catchup/ledgerFetcher.go 13.48% <0.00%> (-25.85%) ⬇️
data/transactions/verify/txn.go 51.15% <0.00%> (-23.97%) ⬇️
tools/network/resolver.go 22.22% <0.00%> (-18.52%) ⬇️
util/codecs/json.go 0.00% <0.00%> (-9.81%) ⬇️
data/transactions/logic/frames.go 93.44% <0.00%> (-6.56%) ⬇️
catchup/catchpointService.go 1.74% <0.00%> (-5.99%) ⬇️
data/transactions/verify/verifiedTxnCache.go 73.46% <0.00%> (-4.09%) ⬇️
data/basics/units.go 56.00% <0.00%> (-4.00%) ⬇️
network/phonebook.go 79.61% <0.00%> (-3.89%) ⬇️
catchup/universalFetcher.go 92.45% <0.00%> (-3.78%) ⬇️
... and 16 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@michaeldiamant michaeldiamant marked this pull request as ready for review November 18, 2022 19:26
@jannotti
Copy link
Contributor

Amazing

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants