txhandler: service does not restart after node catching up #4809
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brianolson
previously approved these changes
Nov 17, 2022
Contributor
brianolson
left a comment
brianolson
left a comment
There was a problem hiding this comment.
this is a remarkably simple and straightforward fix. most of the work was on the test, eh? LGTM.
Codecov Report
@@ Coverage Diff @@
## master #4809 +/- ##
=======================================
Coverage 54.67% 54.68%
=======================================
Files 414 414
Lines 53550 53550
=======================================
+ Hits 29278 29282 +4
Misses 21842 21842
+ Partials 2430 2426 -4
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
brianolson
previously approved these changes
Nov 17, 2022
Contributor
algorandskiy
left a comment
algorandskiy
left a comment
There was a problem hiding this comment.
The fix is good, please tweak the test a bit. Is it stable enough?
algorandskiy
approved these changes
Nov 18, 2022
algorandskiy
changed the title
This was referenced Nov 21, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The txHandler and txSyncer are stopped when catching up from a catchpoint, and started again afterwards.
But they never really start. The main loop of these services rely on a context to stop. That context is canceled when stopping. Then, when the services are started again, the contexts remain canceled, which leads for the service to immediately end.
The fix is to create a new context when starting these services.
This PR fixes the txHandler part of #4775