Skip to content

Conversation

@brianolson
Copy link
Contributor

@brianolson brianolson commented Nov 8, 2022

Summary

Repair features for generating pre-built account database with many accounts already in it (to test sqlite3 account db performance at different sizes).

Test Plan

This is used in cluster tests.

'netgoal' 'build' '-r' '/data/networks/bolson-s3/gen' '-n' 'bolson-s3' '--recipe' 'test/testdata/deployednettemplates/recipes/bootstrappedScenario/recipe.json' '--gen-db-files'

Copy link
Contributor

@algorandskiy algorandskiy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you also post command line on how to generate the db and run a test with it?

}

//initial state
log := logging.NewLogger()
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this inits local var, not global one. Maybe move it into init() ?

@algobarb algobarb requested a review from algolucky November 14, 2022 15:27
@algorandskiy
Copy link
Contributor

@brianolson please rebase on master to fix the build, and add usage examples into the PR description (what to run cli to have 30M accounts pregenerated before the test)

@codecov
Copy link

codecov bot commented Nov 15, 2022

Codecov Report

Merging #4772 (b7930a5) into master (23890a8) will decrease coverage by 0.00%.
The diff coverage is 22.72%.

@@            Coverage Diff             @@
##           master    #4772      +/-   ##
==========================================
- Coverage   54.68%   54.68%   -0.01%     
==========================================
  Files         414      414              
  Lines       53550    53561      +11     
==========================================
+ Hits        29286    29291       +5     
- Misses      21836    21842       +6     
  Partials     2428     2428              
Impacted Files Coverage Δ
netdeploy/remote/deployedNetwork.go 19.55% <22.72%> (-0.22%) ⬇️
agreement/cryptoVerifier.go 67.60% <0.00%> (-2.12%) ⬇️
agreement/proposalManager.go 96.07% <0.00%> (-1.97%) ⬇️
catchup/peerSelector.go 98.95% <0.00%> (-1.05%) ⬇️
catchup/service.go 68.88% <0.00%> (-0.50%) ⬇️
ledger/testing/randomAccounts.go 56.61% <0.00%> (ø)
network/wsPeer.go 69.17% <0.00%> (+0.24%) ⬆️
ledger/tracker.go 77.87% <0.00%> (+3.82%) ⬆️
ledger/roundlru.go 96.22% <0.00%> (+5.66%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@brianolson brianolson marked this pull request as ready for review November 15, 2022 19:12
@algorandskiy algorandskiy merged commit 3ece6bd into algorand:master Nov 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants