Skip to content

Conversation

@jannotti
Copy link
Contributor

@jannotti jannotti commented Nov 1, 2022

Allows upgrade to v36, with boxes.

algorandskiy
algorandskiy previously approved these changes Nov 1, 2022
Copy link
Contributor

@michaeldiamant michaeldiamant left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jannotti Looks accurate to me though I have little experience managing consensus upgrades. I prefer 1+ other approvals prior to merging.

@codecov
Copy link

codecov bot commented Nov 1, 2022

Codecov Report

Merging #4722 (a4db7cb) into master (97c232d) will decrease coverage by 0.00%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master    #4722      +/-   ##
==========================================
- Coverage   54.37%   54.37%   -0.01%     
==========================================
  Files         414      414              
  Lines       53504    53502       -2     
==========================================
- Hits        29095    29091       -4     
- Misses      22002    22007       +5     
+ Partials     2407     2404       -3     
Impacted Files Coverage Δ
data/transactions/logic/opcodes.go 84.56% <ø> (ø)
ledger/testing/consensusRange.go 0.00% <ø> (ø)
protocol/consensus.go 0.00% <ø> (ø)
config/consensus.go 87.53% <100.00%> (+0.16%) ⬆️
ledger/roundlru.go 90.56% <0.00%> (-5.67%) ⬇️
ledger/tracker.go 74.89% <0.00%> (-2.98%) ⬇️
crypto/merkletrie/trie.go 66.42% <0.00%> (-2.19%) ⬇️
crypto/merkletrie/node.go 91.62% <0.00%> (-1.87%) ⬇️
catchup/service.go 68.14% <0.00%> (-0.75%) ⬇️
network/wsPeer.go 68.93% <0.00%> (-0.25%) ⬇️
... and 5 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants