Skip to content

Conversation

@cce
Copy link
Contributor

@cce cce commented Oct 21, 2022

Summary

Rejecting a transaction due to a conflicting lease is a fairly common occurrence, so this demotes its handling from a warning level to an info level event, alongside the MinFeeError. This will also prevent it from being logged to telemetry, which is used for warning and error level messages.

Test Plan

No changes should be seen in tests besides this logging level.

@codecov
Copy link

codecov bot commented Oct 21, 2022

Codecov Report

Merging #4685 (cafe895) into master (b29d7ff) will increase coverage by 0.02%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##           master    #4685      +/-   ##
==========================================
+ Coverage   54.38%   54.40%   +0.02%     
==========================================
  Files         403      403              
  Lines       51928    51928              
==========================================
+ Hits        28243    28254      +11     
+ Misses      21308    21297      -11     
  Partials     2377     2377              
Impacted Files Coverage Δ
data/pools/transactionPool.go 50.69% <0.00%> (ø)
cmd/algoh/blockWatcher.go 77.77% <0.00%> (-3.18%) ⬇️
catchup/peerSelector.go 98.95% <0.00%> (-1.05%) ⬇️
ledger/tracker.go 74.04% <0.00%> (-0.86%) ⬇️
ledger/acctupdates.go 70.19% <0.00%> (+0.59%) ⬆️
data/transactions/verify/txn.go 77.14% <0.00%> (+0.95%) ⬆️
network/wsPeer.go 68.44% <0.00%> (+1.94%) ⬆️
ledger/roundlru.go 96.22% <0.00%> (+5.66%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants