Perf test: Transaction group handle/verify #4652
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #4652 +/- ##
==========================================
+ Coverage 54.34% 54.41% +0.06%
==========================================
Files 402 402
Lines 51793 51793
==========================================
+ Hits 28149 28183 +34
+ Misses 21276 21233 -43
- Partials 2368 2377 +9
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
algonautshant
added
Enhancement
test
algonautshant
changed the title
cce
changed the title
brianolson
reviewed
Oct 24, 2022
Contributor
brianolson
left a comment
brianolson
left a comment
There was a problem hiding this comment.
One tweak, otherwise looks good
| outChan := make(chan *txBacklogMsg, 10) | ||
| wg := sync.WaitGroup{} | ||
| wg.Add(1) | ||
| // Make a test backlog worker, which is simiar to backlogWorker, but sends the results |
Contributor
There was a problem hiding this comment.
add a comment in txHandler.go at backlogWorker() noting that updates should be reflected in this test
brianolson
approved these changes
Oct 24, 2022
algorandskiy
approved these changes
Oct 24, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Performance test for incoming transaction group handling/verifying.
Prepares transaction groups of random sizes, sends them to the handler, which verifies and returns the results.
The transaction group sizes are random. Introduces 10% invalid signatures and makes sure they are properly reported.