Batch-verify: Return failed sig indexes #4614
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #4614 +/- ##
==========================================
+ Coverage 54.20% 54.25% +0.04%
==========================================
Files 402 402
Lines 51803 51810 +7
==========================================
+ Hits 28079 28107 +28
+ Misses 21358 21340 -18
+ Partials 2366 2363 -3
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
algonautshant
changed the base branch from
master
to
batch_verify_incoming_txn
algorandskiy
reviewed
Oct 3, 2022
Contributor
algorandskiy
left a comment
algorandskiy
left a comment
There was a problem hiding this comment.
Looks good, couple notes
id-ms
reviewed
Oct 3, 2022
id-ms
reviewed
Oct 3, 2022
id-ms
reviewed
Oct 6, 2022
id-ms
reviewed
Oct 6, 2022
id-ms
reviewed
Oct 6, 2022
id-ms
reviewed
Oct 6, 2022
id-ms
reviewed
Oct 6, 2022
algonautshant
changed the base branch from
batch_verify_incoming_txn
to
master
id-ms
approved these changes
Oct 6, 2022
algorandskiy
approved these changes
Oct 6, 2022
This was referenced Oct 14, 2022
tmc
pushed a commit
to tmc/go-algorand
that referenced
this pull request
Mar 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR returns the indexes of the failed signatures from Batch Verify.