Tools: update node exporter to ignore malformed metrics #4518
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
onetechnical
requested review from
a team,
algobarb,
algojack,
algolucky,
cce and
egieseke
Codecov Report
@@ Coverage Diff @@
## master #4518 +/- ##
==========================================
- Coverage 55.26% 55.23% -0.04%
==========================================
Files 398 398
Lines 50366 50366
==========================================
- Hits 27836 27820 -16
- Misses 20199 20209 +10
- Partials 2331 2337 +6
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
egieseke
approved these changes
Sep 8, 2022
algojack
approved these changes
Sep 8, 2022
algolucky
approved these changes
Sep 8, 2022
algobarb
approved these changes
Sep 8, 2022
onetechnical
added a commit
to onetechnical/go-algorand
that referenced
this pull request
Sep 8, 2022
This was referenced Sep 8, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Metrics with closing curly brace before open curly brace were breaking node exporter. This pulls in a patched node exporter.
Binaries built here:
https://github.com/algorand/node_exporter/actions/runs/3017995065
Test Plan
N/A