Skip to content

Conversation

@jannotti
Copy link
Contributor

In prep for releases some of our experimental opcodes, but moving some up to the next AVM version, make it easier to do so.

@codecov
Copy link

codecov bot commented Jun 13, 2022

Codecov Report

Merging #4123 (594a51b) into master (ff1a53d) will increase coverage by 0.02%.
The diff coverage is 75.00%.

@@            Coverage Diff             @@
##           master    #4123      +/-   ##
==========================================
+ Coverage   54.51%   54.54%   +0.02%     
==========================================
  Files         391      391              
  Lines       48696    48697       +1     
==========================================
+ Hits        26545    26560      +15     
+ Misses      19928    19918      -10     
+ Partials     2223     2219       -4     
Impacted Files Coverage Δ
data/transactions/logic/opcodes.go 83.76% <ø> (ø)
data/transactions/logic/assembler.go 83.33% <66.66%> (+0.01%) ⬆️
config/consensus.go 85.71% <100.00%> (ø)
ledger/roundlru.go 90.56% <0.00%> (-5.67%) ⬇️
cmd/algoh/blockWatcher.go 77.77% <0.00%> (-3.18%) ⬇️
ledger/blockqueue.go 82.18% <0.00%> (-2.88%) ⬇️
ledger/tracker.go 74.45% <0.00%> (-0.87%) ⬇️
cmd/tealdbg/debugger.go 72.69% <0.00%> (-0.81%) ⬇️
network/wsNetwork.go 64.89% <0.00%> (-0.29%) ⬇️
catchup/service.go 69.62% <0.00%> (+0.74%) ⬆️
... and 6 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ff1a53d...594a51b. Read the comment docs.

jannotti and others added 2 commits June 13, 2022 20:48
Co-authored-by: Michael Diamant <michaeldiamant@users.noreply.github.com>
Co-authored-by: Michael Diamant <michaeldiamant@users.noreply.github.com>
Copy link
Contributor

@michaeldiamant michaeldiamant left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jannotti Thanks for the effort here - it's a definite improvement over #4113! ☕

@jannotti jannotti merged commit bd0f9d6 into algorand:master Jun 14, 2022
@jannotti jannotti deleted the avm-opcode-separation branch June 14, 2022 02:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants