Skip to content

Conversation

@tzaffi
Copy link
Contributor

@tzaffi tzaffi commented Jun 8, 2022

Following up Scytale 5/25/2022 Retro

  • goal README which has a FAQ-like format and currently answers two questions:
    • Having just done a new build in go-algorand, how do I get a single node dev network up, with algos in an easily used wallet from goal?
    • How to make app calls which utilize box storage
  • justfile
    • this is no longer included as part of the PR, but it lives on in this gist

Test Plan

None

@codecov
Copy link

codecov bot commented Jun 8, 2022

Codecov Report

Merging #4095 (5d43a4a) into feature/avm-box (f84af7e) will decrease coverage by 0.01%.
The diff coverage is n/a.

@@                 Coverage Diff                 @@
##           feature/avm-box    #4095      +/-   ##
===================================================
- Coverage            54.55%   54.54%   -0.02%     
===================================================
  Files                  392      392              
  Lines                49085    49085              
===================================================
- Hits                 26779    26773       -6     
- Misses               20049    20056       +7     
+ Partials              2257     2256       -1     
Impacted Files Coverage Δ
network/wsPeer.go 65.47% <0.00%> (-2.20%) ⬇️
ledger/tracker.go 73.16% <0.00%> (-1.30%) ⬇️
network/wsNetwork.go 64.70% <0.00%> (-0.20%) ⬇️
data/transactions/verify/txn.go 45.02% <0.00%> (+0.86%) ⬆️
util/metrics/reporter.go 61.16% <0.00%> (+4.85%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f84af7e...5d43a4a. Read the comment docs.

Copy link
Contributor

@algochoi algochoi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great! The instructions were easy to follow, and I think it's nice to have some examples documented for developers in a centralized location (I sometimes forget how to run commands time to time). I agree that pushing the justfiles here might cause more headaches - maybe we can put it in some dev-rel repo instead?

tzaffi and others added 4 commits June 9, 2022 11:15
Co-authored-by: algochoi <86622919+algochoi@users.noreply.github.com>
Copy link
Contributor

@michaeldiamant michaeldiamant left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tzaffi Thanks for the follow up here - looks good to me.

@tzaffi
Copy link
Contributor Author

tzaffi commented Jun 15, 2022

@tzaffi Thanks for the follow up here - looks good to me.

I'll wait for tests to pass before merging

@algochoi algochoi self-requested a review June 15, 2022 19:00
@tzaffi tzaffi merged commit 10e29e1 into algorand:feature/avm-box Jun 15, 2022
@tzaffi tzaffi deleted the readme-examples-for-goal branch June 15, 2022 19:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants