-
Notifications
You must be signed in to change notification settings - Fork 524
README.md as committed to in the last retro + just for temporary fun: justfile #4095
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
README.md as committed to in the last retro + just for temporary fun: justfile #4095
Conversation
Codecov Report
@@ Coverage Diff @@
## feature/avm-box #4095 +/- ##
===================================================
- Coverage 54.55% 54.54% -0.02%
===================================================
Files 392 392
Lines 49085 49085
===================================================
- Hits 26779 26773 -6
- Misses 20049 20056 +7
+ Partials 2257 2256 -1
Continue to review full report at Codecov.
|
algochoi
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is great! The instructions were easy to follow, and I think it's nice to have some examples documented for developers in a centralized location (I sometimes forget how to run commands time to time). I agree that pushing the justfiles here might cause more headaches - maybe we can put it in some dev-rel repo instead?
Co-authored-by: algochoi <86622919+algochoi@users.noreply.github.com>
…and into readme-examples-for-goal
…llation and goal's executable path
…and into readme-examples-for-goal
michaeldiamant
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@tzaffi Thanks for the follow up here - looks good to me.
I'll wait for tests to pass before merging |
Following up Scytale 5/25/2022 Retro
justfileTest Plan
None