netdeploy: Allow empty private network directory. #3911
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
winder
force-pushed
the
will/allow-empty-network-dir
branch
2 times, most recently
from
4307ac0 to
059b205
Compare
In order to run private networks in docker, it is convenient to mount the data directory. By disallowing the network directory to exist it is not possible to mount the node directory.
winder
force-pushed
the
will/allow-empty-network-dir
branch
from
059b205 to
1a3f137
Compare
shiqizng
previously approved these changes
Apr 25, 2022
Contributor
algorandskiy
left a comment
algorandskiy
left a comment
There was a problem hiding this comment.
Good change, a small suggestion to decrease nesting - see below
algorandskiy
approved these changes
Apr 27, 2022
This was referenced May 2, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
In order to run private networks in docker, it is convenient to mount
the data directory. By disallowing the network directory to exist it is
not possible to mount the node directory ahead of time.
Test Plan
Unit test for new utility function.