Skip to content

goal: Rename source map output file #3905

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
michaeldiamant merged 3 commits into from
Apr 22, 2022
Merged

goal: Rename source map output file #3905

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
aed24e2
Rename sourcemap out file
algochoi Apr 21, 2022
1d92164
Address edge case where outfile name is -
algochoi Apr 21, 2022
23d2f33
Error if source map is output to stdout
algochoi Apr 21, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion cmd/goal/clerk.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1070,7 +1070,10 @@ var compileCmd = &cobra.Command{
}
}
if writeSourceMap {
mapname := fname + ".map"
if outname == stdoutFilenameValue {
reportErrorf("%s: %s", outname, "cannot print map to stdout")
}
mapname := outname + ".map"
pcblob, err := json.Marshal(sourceMap)
if err != nil {
reportErrorf("%s: %s", mapname, err)
Expand Down
2 changes: 1 addition & 1 deletion test/scripts/e2e_subs/e2e-teal.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -155,7 +155,7 @@ printf '\x02' | dd of=${TEMPDIR}/true2.lsig bs=1 seek=0 count=1 conv=notrunc
# we do this in place and clean up the file later.
${gcmd} clerk compile ${TEAL}/quine.teal -m
trap 'rm ${TEAL}/quine.teal.*' EXIT
if ! diff ${TEAL}/quine.map ${TEAL}/quine.teal.map; then
if ! diff ${TEAL}/quine.map ${TEAL}/quine.teal.tok.map; then
echo "produced source maps do not match"
exit 1
fi
Expand Down