Skip to content

Conversation

@egieseke
Copy link
Contributor

Summary

Added "txnsync" recipe matching configuration requirements for txn sync testing on Betanet.

Test Plan

Tested recipe by using algonet to launch a network. Verified that the rounds were progressing.

Copy link
Contributor

@algobarb algobarb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this just for Phase0 testing and a Betanet replica? Or would this be the format used for the Betanet Deployment?
Betanet TxnSync deployement would need 4 betanet relays and 10 additional non-participation nodes using m5d.xlarge machines, geo-distributed. I see participation nodes and that all the nodes here are c5.4xlarge machines and in us-east-2. Can we clarify the purpose of the recipe?

@egieseke
Copy link
Contributor Author

Is this just for Phase0 testing and a Betanet replica? Or would this be the format used for the Betanet Deployment? Betanet TxnSync deployement would need 4 betanet relays and 10 additional non-participation nodes using m5d.xlarge machines, geo-distributed. I see participation nodes and that all the nodes here are c5.4xlarge machines and in us-east-2. Can we clarify the purpose of the recipe?

@algobarb This recipe is used to create the betanet network extension for the txn sync testing. I used c5.4xlarge machines to match what was used for the current betanet relays and nodes based on "Create R6..R9 on different geo-zones. Use the same host configuration used for the rest of the betanet relays." and "Create 5 hosts, using the same host configuration as R5". We can easily change to md5.xlarge if those are required.

I will update the recipe to spread out to different regions, good catch!

@egieseke egieseke requested a review from algobarb April 13, 2022 21:35
@codecov-commenter
Copy link

codecov-commenter commented Apr 13, 2022

Codecov Report

Merging #3884 (6ed26f6) into master (85a02f7) will increase coverage by 0.03%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #3884      +/-   ##
==========================================
+ Coverage   49.97%   50.01%   +0.03%     
==========================================
  Files         393      393              
  Lines       68211    68211              
==========================================
+ Hits        34089    34114      +25     
+ Misses      30417    30399      -18     
+ Partials     3705     3698       -7     
Impacted Files Coverage Δ
ledger/acctupdates.go 69.30% <0.00%> (+0.13%) ⬆️
catchup/service.go 69.38% <0.00%> (+0.49%) ⬆️
data/transactions/verify/txn.go 45.02% <0.00%> (+0.86%) ⬆️
data/abi/abi_type.go 88.62% <0.00%> (+0.94%) ⬆️
cmd/tealdbg/debugger.go 72.41% <0.00%> (+0.98%) ⬆️
crypto/merkletrie/node.go 93.48% <0.00%> (+1.86%) ⬆️
network/wsPeer.go 68.05% <0.00%> (+1.94%) ⬆️
crypto/merkletrie/trie.go 68.61% <0.00%> (+2.18%) ⬆️
cmd/algoh/blockWatcher.go 80.95% <0.00%> (+3.17%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 85a02f7...6ed26f6. Read the comment docs.

@algobarb
Copy link
Contributor

@algobarb algobarb closed this Apr 14, 2022
@algobarb algobarb reopened this Apr 14, 2022
@algobarb
Copy link
Contributor

algobarb commented Apr 14, 2022

Is this just for Phase0 testing and a Betanet replica? Or would this be the format used for the Betanet Deployment? Betanet TxnSync deployement would need 4 betanet relays and 10 additional non-participation nodes using m5d.xlarge machines, geo-distributed. I see participation nodes and that all the nodes here are c5.4xlarge machines and in us-east-2. Can we clarify the purpose of the recipe?

@algobarb This recipe is used to create the betanet network extension for the txn sync testing. I used c5.4xlarge machines to match what was used for the current betanet relays and nodes based on "Create R6..R9 on different geo-zones. Use the same host configuration used for the rest of the betanet relays." and "Create 5 hosts, using the same host configuration as R5". We can easily change to md5.xlarge if those are required.

I will update the recipe to spread out to different regions, good catch!

"Expected cost: Use m5d.xlarge for each of the relays/nodes." under BetaNet Deployment in the Deployment doc. Host configuration is still the same, but machine type was supposed to be different, but John may not mind if it's c5.4xlarge. When we reviewed the documentation we settled on that we need a total of 9 machines: 4 machines with 1 Relay each, and then 5 machines with 2 NPN each. So we'll have to adjust this and maybe have a review with John since Tsachi is out {"R":4, "N":5, "NPN":1} should be {"R":4, "N":0, "NPN":10}?
It's nice that you've got it to work though so that adjusting the requirements would be much easier than if we had manually spun these up.

Copy link
Contributor

@algobarb algobarb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for clarifying. I wasn't sure if there was a need for them to be NPN in the original doc.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants