agreement: add counters for dropped tasks and slow responses #3861
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…low pseudonode responses
brianolson
approved these changes
Apr 6, 2022
Codecov Report
@@ Coverage Diff @@
## master #3861 +/- ##
==========================================
+ Coverage 49.95% 49.97% +0.01%
==========================================
Files 393 393
Lines 68353 68359 +6
==========================================
+ Hits 34149 34160 +11
+ Misses 30473 30469 -4
+ Partials 3731 3730 -1
Continue to review full report at Codecov.
|
ghost
approved these changes
Apr 12, 2022
This was referenced Apr 27, 2022
This was referenced May 2, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
In #2741 we added some additional logging for cases where the pseudonode tasks queues (used by MakeVotes and MakeProposals) were full, or if the cryptoVerifier response queue was full, or if it was taking more than 2s to wait for a verifier task to return. This adds counters to accompany those log messages.
Test Plan
Existing tests should pass.