Bug-Fix: ABI inferToSlice nil testcases #3826
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michaeldiamant
previously approved these changes
Mar 23, 2022
Contributor
michaeldiamant
left a comment
michaeldiamant
left a comment
There was a problem hiding this comment.
@ahangsu Thanks for bringing in my feedback around additional test cases. ☕
jannotti
reviewed
Mar 23, 2022
ahangsu
dismissed stale reviews from michaeldiamant and jasonpaulos
via
6718b51
jasonpaulos
previously approved these changes
Mar 23, 2022
jannotti
previously approved these changes
Mar 23, 2022
ahangsu
changed the title
ahangsu
changed the title
Codecov Report
@@ Coverage Diff @@
## master #3826 +/- ##
=======================================
Coverage 49.99% 49.99%
=======================================
Files 392 392
Lines 68495 68491 -4
=======================================
- Hits 34242 34240 -2
+ Misses 30497 30496 -1
+ Partials 3756 3755 -1
Continue to review full report at Codecov.
|
michaeldiamant
approved these changes
Mar 24, 2022
Contributor
michaeldiamant
left a comment
michaeldiamant
left a comment
There was a problem hiding this comment.
@ahangsu Thanks for the effort to add test cases here. ☕
This was referenced Apr 27, 2022
This was referenced May 2, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
A follow-up PR from #3823, adding one moar testcase to test
inferToSlicewill error when passing anilwith unexpected type (i.e., type other than slice or array).