Skip to content

Conversation

@cce
Copy link
Contributor

@cce cce commented Mar 19, 2022

Summary

The changes in #3770 didn't include the changes in #3769 and so tests don't compile on master currently — this updates another test that uses Totals to use LatestTotals instead.

Test Plan

Fixes tests.

@cce cce added the Bug-Fix label Mar 19, 2022
@cce cce self-assigned this Mar 19, 2022
@codecov-commenter
Copy link

codecov-commenter commented Mar 19, 2022

Codecov Report

Merging #3804 (c382647) into master (af3b5d3) will decrease coverage by 0.04%.
The diff coverage is 22.38%.

@@            Coverage Diff             @@
##           master    #3804      +/-   ##
==========================================
- Coverage   49.88%   49.84%   -0.05%     
==========================================
  Files         392      392              
  Lines       68685    68719      +34     
==========================================
- Hits        34264    34250      -14     
- Misses      30669    30714      +45     
- Partials     3752     3755       +3     
Impacted Files Coverage Δ
cmd/goal/account.go 12.94% <0.00%> (ø)
cmd/goal/application.go 11.16% <0.00%> (ø)
cmd/goal/clerk.go 9.03% <0.00%> (-0.20%) ⬇️
cmd/goal/commands.go 10.40% <0.00%> (-0.04%) ⬇️
cmd/goal/logging.go 8.92% <0.00%> (ø)
data/abi/abi_encode.go 61.26% <0.00%> (-2.82%) ⬇️
ledger/ledger.go 60.79% <0.00%> (+0.59%) ⬆️
node/node.go 23.26% <0.00%> (-0.08%) ⬇️
compactcert/builder.go 65.57% <100.00%> (ø)
data/abi/abi_type.go 88.62% <100.00%> (ø)
... and 11 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8ac7c8b...c382647. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants