Algod: Fix issue with nil accounts in local-deltas array #3790
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jannotti
previously approved these changes
Mar 17, 2022
Contributor
jannotti
left a comment
jannotti
left a comment
There was a problem hiding this comment.
This looks like it's clearly the right fix. Can we add a unit test to make sure this never regresses?
algorandskiy
approved these changes
Mar 25, 2022
This was referenced Apr 27, 2022
This was referenced May 2, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the second issue with making a slice of a given length but then appending to it instead of setting elements by index.
We probably should look through to see where/if this is done elsewhere.
Result of this bug prior to the fix, note txns[0]['local-deltas'][0] here:
https://raw.githubusercontent.com/algorand/algorand-sdk-testing/131b0d90f5a1c4c93b43b7f5b4126c568dc29613/features/resources/v2algodclient_responsejsons/largeDryrunResponse.json