DevMode: create a block for external txns only #3784
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rt creation event)
tsachiherman
previously approved these changes
Mar 17, 2022
tsachiherman
previously approved these changes
Mar 17, 2022
Contributor
algorandskiy
left a comment
algorandskiy
left a comment
There was a problem hiding this comment.
I understand the fix but I do not really like BroadcastCompactCertSignedTxGroup function that bypasses devmode for compact cert.
Maybe add some code into BroadcastSignedTxGroup for txn group analysis and bypass devnode for the internal transactions like compact cert?
node/node.go
Outdated
| return node.broadcastSignedTxGroup(txgroup) | ||
| } | ||
|
|
||
| // BroadcastCompactCertSignedTxGroup broadcasts a transaction group that has already been signed. |
Contributor
There was a problem hiding this comment.
Explain the difference with BroadcastSignedTxGroup in a comment?
Codecov Report
@@ Coverage Diff @@
## master #3784 +/- ##
==========================================
- Coverage 49.88% 49.85% -0.03%
==========================================
Files 392 392
Lines 68685 68687 +2
==========================================
- Hits 34264 34247 -17
- Misses 30669 30685 +16
- Partials 3752 3755 +3
Continue to review full report at Codecov.
|
tsachiherman
approved these changes
Mar 18, 2022
algorandskiy
approved these changes
Mar 18, 2022
This was referenced Apr 27, 2022
This was referenced May 2, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In DevMode, do not create a block for internal events (i.e. compact-cert creation).
This is to assure reproducibility and eliminate the random shifts in round numbers.