crypto: remove batch verification flag #3781
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
id-ms
force-pushed
the
remove-batchverification-flag
branch
from
1dd6801 to
ac8eb28
Compare
id-ms
force-pushed
the
remove-batchverification-flag
branch
from
ac8eb28 to
1a11785
Compare
added 2 commits
May 3, 2022 15:40
added 2 commits
May 3, 2022 17:05
Codecov Report
@@ Coverage Diff @@
## master #3781 +/- ##
==========================================
+ Coverage 49.80% 54.49% +4.68%
==========================================
Files 409 390 -19
Lines 68929 48411 -20518
==========================================
- Hits 34332 26382 -7950
+ Misses 30891 19803 -11088
+ Partials 3706 2226 -1480
Continue to review full report at Codecov.
|
gmalouf
requested review from
algorandskiy and
jannotti
and removed request for
tsachiherman
algorandskiy
approved these changes
Jun 2, 2022
Contributor
algorandskiy
left a comment
algorandskiy
left a comment
There was a problem hiding this comment.
Given the node was caught up from block 1 to the latest under extended verification settings, looks good to go.
tmc
pushed a commit
to tmc/go-algorand
that referenced
this pull request
Mar 7, 2025
Always use the new (batch) verification system, having confirmed no incompatibilities with existing blockchain.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
On V32 we introduced the batch verification for ed25519 signatures. In order to sync all nodes on the new algorithm, we added a new consensus param field.
Since the network accepted the V32 version, we can use the new algorithm on historical signatures.
Test Plan
Run full catchup test on Testnet, betanet and main net while configuring the node the verify signatures for old blocks.