AVM: Sha3-256

THANKS.md

@@ -9,6 +9,7 @@ A big thank you to everyone who has contributed to the `go-algorand` codebase.
 - jeapostrophe
 - jecassis
 - jsign
+- Matt-Ryley
 - mxmauro
 - Olshansk
 - qkniep

data/transactions/logic/README.md

@@ -267,6 +267,7 @@ return stack matches the name of the input value.
 | `sha256` | SHA256 hash of value A, yields [32]byte |
 | `keccak256` | Keccak256 hash of value A, yields [32]byte |
 | `sha512_256` | SHA512_256 hash of value A, yields [32]byte |
+| `sha3_256` | SHA3_256 hash of value A, yields [32]byte |
 | `ed25519verify` | for (data A, signature B, pubkey C) verify the signature of ("ProgData" \|\| program_hash \|\| data) against the pubkey => {0 or 1} |
 | `ecdsa_verify v` | for (data A, signature B, C and pubkey D, E) verify the signature of the data against the pubkey => {0 or 1} |
 | `ecdsa_pk_recover v` | for (data A, recovery id B, signature C, D) recover a public key |

data/transactions/logic/TEAL_opcodes.md

@@ -1093,6 +1093,14 @@ bitlen interprets arrays as big-endian integers, unlike setbit/getbit
 
 The notation A,B indicates that A and B are interpreted as a uint128 value, with A as the high uint64 and B the low.
 
+## sha3_256
+
+- Opcode: 0x98
+- Stack: ..., A: []byte → ..., []byte
+- SHA3_256 hash of value A, yields [32]byte
+- **Cost**: 130
+- Availability: v7
+
 ## b+
 
 - Opcode: 0xa0

data/transactions/logic/assembler_test.go

@@ -370,11 +370,12 @@ pushbytes 0x0123456789abcd
 dup
 dup
 ecdsa_verify Secp256r1
+sha3_256
 `
 
 const v6Compiled = "2004010002b7a60c26050242420c68656c6c6f20776f726c6421070123456789abcd208dae2087fbba51304eb02b91f656948397a7946390e8cb70fc9ea4d95f92251d047465737400320032013202320380021234292929292b0431003101310231043105310731083109310a310b310c310d310e310f3111311231133114311533000033000133000233000433000533000733000833000933000a33000b33000c33000d33000e33000f3300113300123300133300143300152d2e01022581f8acd19181cf959a1281f8acd19181cf951a81f8acd19181cf1581f8acd191810f082209240a220b230c240d250e230f23102311231223132314181b1c28171615400003290349483403350222231d4a484848482b50512a632223524100034200004322602261222704634848222862482864286548482228246628226723286828692322700048482371004848361c0037001a0031183119311b311d311e311f312023221e312131223123312431253126312731283129312a312b312c312d312e312f447825225314225427042455220824564c4d4b0222382124391c0081e80780046a6f686e2281d00f23241f880003420001892224902291922494249593a0a1a2a3a4a5a6a7a8a9aaabacadae24af3a00003b003c003d816472064e014f012a57000823810858235b235a2359b03139330039b1b200b322c01a23c1001a2323c21a23c3233e233f8120af06002a494905002a49490700b53a03b6b7043cb8033a0c2349c42a9631007300810881088120978101c53a8101c6003a"
 
-const v7Compiled = v6Compiled + "5c005d018120af060180070123456789abcd49490501"
+const v7Compiled = v6Compiled + "5c005d018120af060180070123456789abcd4949050198"
 
 var nonsense = map[uint64]string{
 	1: v1Nonsense,

data/transactions/logic/doc.go

@@ -26,6 +26,7 @@ var opDocByName = map[string]string{
 	"sha256":              "SHA256 hash of value A, yields [32]byte",
 	"keccak256":           "Keccak256 hash of value A, yields [32]byte",
 	"sha512_256":          "SHA512_256 hash of value A, yields [32]byte",
+	"sha3_256":            "SHA3_256 hash of value A, yields [32]byte",
 	"ed25519verify":       "for (data A, signature B, pubkey C) verify the signature of (\"ProgData\" || program_hash || data) against the pubkey => {0 or 1}",
 	"ecdsa_verify":        "for (data A, signature B, C and pubkey D, E) verify the signature of the data against the pubkey => {0 or 1}",
 	"ecdsa_pk_decompress": "decompress pubkey A into components X, Y",
@@ -332,7 +333,7 @@ func OpDocExtra(opName string) string {
 // here is the order args opcodes are presented, so place related
 // opcodes consecutively, even if their opcode values are not.
 var OpGroups = map[string][]string{
-	"Arithmetic":              {"sha256", "keccak256", "sha512_256", "ed25519verify", "ecdsa_verify", "ecdsa_pk_recover", "ecdsa_pk_decompress", "+", "-", "/", "*", "<", ">", "<=", ">=", "&&", "||", "shl", "shr", "sqrt", "bitlen", "exp", "==", "!=", "!", "len", "itob", "btoi", "%", "|", "&", "^", "~", "mulw", "addw", "divw", "divmodw", "expw", "getbit", "setbit", "getbyte", "setbyte", "concat"},
+	"Arithmetic":              {"sha256", "keccak256", "sha512_256", "sha3_256", "ed25519verify", "ecdsa_verify", "ecdsa_pk_recover", "ecdsa_pk_decompress", "+", "-", "/", "*", "<", ">", "<=", ">=", "&&", "||", "shl", "shr", "sqrt", "bitlen", "exp", "==", "!=", "!", "len", "itob", "btoi", "%", "|", "&", "^", "~", "mulw", "addw", "divw", "divmodw", "expw", "getbit", "setbit", "getbyte", "setbyte", "concat"},
 	"Byte Array Manipulation": {"substring", "substring3", "extract", "extract3", "extract_uint16", "extract_uint32", "extract_uint64", "base64_decode", "json_ref"},
 	"Byte Array Arithmetic":   {"b+", "b-", "b/", "b*", "b<", "b>", "b<=", "b>=", "b==", "b!=", "b%", "bsqrt"},
 	"Byte Array Logic":        {"b|", "b&", "b^", "b~"},

data/transactions/logic/eval.go

@@ -1101,6 +1101,13 @@ func opSHA256(cx *EvalContext) {
 	cx.stack[last].Bytes = hash[:]
 }
 
+// The NIST SHA3-256 is implemented for compatibility with ICON
+func opSHA3_256(cx *EvalContext) {
+	last := len(cx.stack) - 1
+	hash := sha3.Sum256(cx.stack[last].Bytes)
+	cx.stack[last].Bytes = hash[:]
+}
+
 // The Keccak256 variant of SHA-3 is implemented for compatibility with Ethereum
 func opKeccak256(cx *EvalContext) {
 	last := len(cx.stack) - 1

data/transactions/logic/evalCrypto_test.go

@@ -54,6 +54,22 @@ byte 0xc195eca25a6f4c82bfba0287082ddb0d602ae9230f9cf1f1a40b68f8e2c41567
 	testAccepts(t, progText, 1)
 }
 
+func TestSHA3_256(t *testing.T) {
+	partitiontest.PartitionTest(t)
+
+	t.Parallel()
+	/*
+		pip install hashlib
+		import hashlib
+		hashlib.sha3_256(b"fnord").hexdigest()
+	*/
+	progText := `byte 0x666E6F7264
+sha3_256
+byte 0xd757297405c5c89f7ceca368ee76c2f1893ee24f654e60032e65fb53b01aae10
+==`
+	testAccepts(t, progText, 7)
+}
+
 func TestSHA512_256(t *testing.T) {
 	partitiontest.PartitionTest(t)
 

data/transactions/logic/evalStateful_test.go

@@ -77,6 +77,7 @@ bytec 0
 sha256
 keccak256
 sha512_256
+sha3_256
 len
 intc_0
 +

data/transactions/logic/eval_test.go

@@ -3475,6 +3475,7 @@ func BenchmarkBase64Decode(b *testing.B) {
 		"keccak256",
 		"sha256",
 		"sha512_256",
+		"sha3_256",
 		"base64_decode StdEncoding",
 		"base64_decode URLEncoding",
 	}
@@ -4937,7 +4938,6 @@ func TestOpJSONRef(t *testing.T) {
 
 	for _, s := range testCases {
 		for v := uint64(2); v < fidoVersion; v++ {
-			fmt.Printf("%d->%s\n", v, s.source)
 			expectedErrs := s.previousVersErrors
 			if fidoVersion <= AssemblerMaxVersion {
 				for i := range expectedErrs {
@@ -5127,7 +5127,6 @@ func TestOpJSONRef(t *testing.T) {
 
 	for _, s := range failedCases {
 		for v := uint64(2); v < fidoVersion; v++ {
-			fmt.Printf("%d->%s\n", v, s.source)
 			expectedErrs := s.previousVersErrors
 			if fidoVersion <= AssemblerMaxVersion {
 				for i := range expectedErrs {

data/transactions/logic/opcodes.go

@@ -316,6 +316,7 @@ var OpSpecs = []OpSpec{
 	{0x95, "expw", opExpw, asmDefault, disDefault, twoInts, twoInts, 4, modeAny, costly(10)},
 	{0x96, "bsqrt", opBytesSqrt, asmDefault, disDefault, oneBytes, oneBytes, 6, modeAny, costly(40)},
 	{0x97, "divw", opDivw, asmDefault, disDefault, twoInts.plus(oneInt), oneInt, 6, modeAny, opDefault},
+	{0x98, "sha3_256", opSHA3_256, asmDefault, disDefault, oneBytes, oneBytes, 7, modeAny, costly(130)},
 
 	// Byteslice math.
 	{0xa0, "b+", opBytesPlus, asmDefault, disDefault, twoBytes, oneBytes, 4, modeAny, costly(10)},