ledger: move prefetcher to a new package #3735
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tsachiherman
suggested changes
Mar 9, 2022
Contributor
tsachiherman
left a comment
tsachiherman
left a comment
There was a problem hiding this comment.
I think that the interfaces sub package is an overkill for what you're trying to do.
In the prefetcher, just create a Ledger interface that would contain the entries that you need.
try to make the eval_prefertcher_alignment_test into a prefetcher_test package, so that it could access both the internal as well as the internal/prefetcher.
tsachiherman
approved these changes
Mar 9, 2022
Codecov Report
@@ Coverage Diff @@
## master #3735 +/- ##
==========================================
+ Coverage 49.65% 49.68% +0.03%
==========================================
Files 392 392
Lines 68588 68588
==========================================
+ Hits 34059 34081 +22
+ Misses 30781 30769 -12
+ Partials 3748 3738 -10
Continue to review full report at Codecov.
|
jannotti
pushed a commit
to jannotti/go-algorand
that referenced
this pull request
Mar 13, 2022
## Summary Move eval prefetcher to its own package for better isolation. Some other refactoring was necessary. ## Test Plan This is refactoring.
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Move eval prefetcher to its own package for better isolation. Some other refactoring was necessary.
Test Plan
This is refactoring.