ledger: add StateProofID to AccountData.ClearOnlineState() #3643
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tsachiherman
previously requested changes
Feb 16, 2022
Contributor
tsachiherman
left a comment
tsachiherman
left a comment
There was a problem hiding this comment.
while I do agree with this change, we can't implement it like this.
Contributor
|
I think that this should be implemented with a future flag. Then, we'll be able to merge it to master. |
Contributor
|
I think we need a hotfix into betanet |
Contributor
|
I would suggest we move those fields into a new struct and clean the entire struct. |
algorandskiy
approved these changes
Feb 17, 2022
Contributor
Author
|
@algoidan we've already moved the fields into a VotingData{} struct on the feature/unlimited-assets branch, and I just made the change you suggested to clear the entire struct here: a5e867f |
id-ms
reviewed
Feb 17, 2022
id-ms
approved these changes
Feb 17, 2022
tsachiherman
approved these changes
Feb 17, 2022
Merged
onetechnical
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Clear out AccountData.StateProofID when ClearOnlineState() is called, by resetExpiredOnlineAccountsParticipationKeys (as part of #2924)
Test Plan
Updated TestExpiredAccountGeneration to generate random online account data, so that it fails without this change.