testing: remove Parallel from txnproofs and fix timeout bug #3628
Conversation
id-ms
force-pushed
the
remove-parallel-from-testtxnmerkleproof
branch
from
243f2b0 to
f3fea11
Compare
| t.Fatal("it is currently round 0 but we need to wait for a transaction that might happen this round but we'll never know if that happens because ConfirmedRound==0 is indestinguishable from not having happened") | ||
| } | ||
| timeoutTime := time.Now().Add(30 * time.Second) | ||
| timeoutTime := time.Now().Add(timeout) |
There was a problem hiding this comment.
we're using this method in 6 places : in 3 calls we pass in 15 seconds, and in 3 calls we pass 30 seconds.
so, for the cases where the timeout was 15 second, we're going to wait now 15 seconds instead of 30 seconds.
Would that trigger any fail cases ?
There was a problem hiding this comment.
I think we should increase the timeout to be at least 30 sec.
what do you think?
There was a problem hiding this comment.
(note that I do think that this is the correct course of action)
Codecov Report
@@ Coverage Diff @@
## master #3628 +/- ##
=======================================
Coverage 48.06% 48.06%
=======================================
Files 381 381
Lines 62080 62080
=======================================
+ Hits 29836 29841 +5
+ Misses 28822 28816 -6
- Partials 3422 3423 +1
Continue to review full report at Codecov.
|
onetechnical
changed the title
3 participants
Summary
Fix a bug in the REST API testing.
Test Plan
Run via CircleCI.