testing: fix participation key expiration tests #3621
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #3621 +/- ##
==========================================
- Coverage 48.06% 48.03% -0.03%
==========================================
Files 381 381
Lines 62080 62080
==========================================
- Hits 29836 29819 -17
- Misses 28822 28835 +13
- Partials 3422 3426 +4
Continue to review full report at Codecov.
|
Contributor
tsachiherman
left a comment
tsachiherman
left a comment
There was a problem hiding this comment.
The changes here aren't bad, and probably would fix the failure; however, I do have few comments :
- The test contains several calls to
GetBalanceAndRound; most of them ignores the balance completely. Why don't we replace these with GetStatus() instead. - The added
sClient.WaitForRound(richAccountLatestRound)makes sense, however, I would suggest replacing it withsClient.WaitForRound(lastValidRound+1)which aligns with the round number that the primary node was waited for.
tsachiherman
changed the title
tsachiherman
approved these changes
Feb 14, 2022
Contributor
tsachiherman
left a comment
tsachiherman
left a comment
There was a problem hiding this comment.
looks good to me. thanks for the changes.
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
I've encountered an issue with the participation keys expiration test, which might cause flakiness.
Test Plan
I've managed to reproduce the same error as shown in
https://app.circleci.com/pipelines/github/algorand/go-algorand/5013/workflows/8c1f10b2-c827-4c0a-81a3-cfe18ec0c794/jobs/78980
By halting the secondary prior to the request of sclient for the round the rich client has.