catchpointdump: set genesis proto version #3596
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Catchpointdump does not have access to a ledger and it does not know
which consensus params is to use as genesis state on rewards calculation
that can lead to division by zero panic.
This PR sets a hardcoded value to
ConsensusCurrentVersion.Additionally, let
netsubcommand to return non-zero exit codeto indicate nothing was downloaded.
To do that I converted it to
cobra.RunE-style method in order to usea standard cobra's error reporting and exit code setter.
Test Plan
Tested manually