Skip to content

Conversation

@michaeldiamant
Copy link
Contributor

Summary

Adds inline comment explaining how the team decided to drop support for inner transactions in a clear state program.

  • Relates to Inner clearstate #3556.
  • Consider the PR optional. As a new team member, I felt the comment benefits future readers' comprehension. If folks feel the explanation is obvious, then I welcome closing the PR.

Test Plan

N/A - Only changes comments.

@codecov-commenter
Copy link

codecov-commenter commented Feb 7, 2022

Codecov Report

Merging #3586 (73ff06b) into feature/contract-to-contract (9fca1ee) will increase coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@                       Coverage Diff                        @@
##           feature/contract-to-contract    #3586      +/-   ##
================================================================
+ Coverage                         47.76%   47.78%   +0.01%     
================================================================
  Files                               370      370              
  Lines                             60258    60258              
================================================================
+ Hits                              28783    28792       +9     
+ Misses                            28171    28163       -8     
+ Partials                           3304     3303       -1     
Impacted Files Coverage Δ
data/transactions/logic/eval.go 85.69% <ø> (ø)
network/wsNetwork.go 62.79% <0.00%> (-0.20%) ⬇️
ledger/acctupdates.go 66.60% <0.00%> (+0.18%) ⬆️
catchup/service.go 70.12% <0.00%> (+0.49%) ⬆️
network/requestTracker.go 71.12% <0.00%> (+0.86%) ⬆️
data/abi/abi_type.go 88.62% <0.00%> (+0.94%) ⬆️
network/netprio.go 78.26% <0.00%> (+8.69%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9fca1ee...73ff06b. Read the comment docs.

@michaeldiamant michaeldiamant deleted the feature/contract-to-contract_comment branch February 7, 2022 19:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants