Skip to content

Conversation

@michaeldiamant
Copy link
Contributor

Summary

Updates ledger README reference to tracker source code.

Since trackers.go does not exist, I assume the appropriate reference is tracker.go.

Test Plan

Since the change only impacts docs, I visually confirmed Markdown rendering.

@codecov-commenter
Copy link

Codecov Report

Merging #3540 (2b3baa3) into master (93a372d) will decrease coverage by 0.00%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3540      +/-   ##
==========================================
- Coverage   47.57%   47.56%   -0.01%     
==========================================
  Files         370      370              
  Lines       60060    60060              
==========================================
- Hits        28572    28570       -2     
- Misses      28178    28181       +3     
+ Partials     3310     3309       -1     
Impacted Files Coverage Δ
util/metrics/gauge.go 68.00% <0.00%> (-2.67%) ⬇️
util/metrics/counter.go 78.57% <0.00%> (-2.39%) ⬇️
agreement/cryptoVerifier.go 75.17% <0.00%> (-2.13%) ⬇️
agreement/proposalManager.go 96.07% <0.00%> (-1.97%) ⬇️
catchup/service.go 68.88% <0.00%> (-1.24%) ⬇️
network/requestTracker.go 70.25% <0.00%> (-0.87%) ⬇️
data/transactions/verify/txn.go 44.29% <0.00%> (ø)
network/wsNetwork.go 63.29% <0.00%> (+0.29%) ⬆️
data/abi/abi_type.go 89.57% <0.00%> (+0.94%) ⬆️
ledger/acctupdates.go 66.73% <0.00%> (+1.14%) ⬆️
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 93a372d...2b3baa3. Read the comment docs.

Copy link
Contributor

@tzaffi tzaffi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tsachiherman tsachiherman merged commit cd19002 into master Jan 31, 2022
@tsachiherman tsachiherman deleted the ledger_readme_typo branch January 31, 2022 19:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants