Add Version KV to telemetry events #3341
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #3341 +/- ##
==========================================
- Coverage 47.74% 47.73% -0.02%
==========================================
Files 370 370
Lines 60262 60270 +8
==========================================
- Hits 28774 28768 -6
- Misses 28180 28191 +11
- Partials 3308 3311 +3
Continue to review full report at Codecov.
|
winder
reviewed
Jan 6, 2022
winder
reviewed
Jan 6, 2022
winder
previously requested changes
Jan 6, 2022
Contributor
winder
left a comment
winder
left a comment
There was a problem hiding this comment.
Looks good, just noticed one small bug
Co-authored-by: Will Winder <wwinder.unh@gmail.com>
tsachiherman
approved these changes
Feb 10, 2022
Merged
tsachiherman
pushed a commit
that referenced
this pull request
Mar 4, 2022
## Summary In #3341 I neglected to notice there are two places that generate telemetry configuration, ReadTelemetryConfigOrDefault and EnsureTelemetryConfigCreated. This updates the latter. ## Test Plan Updated tests to check and handle new default.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This piggybacks off the places where "session" is added to telemetry events, to additionally add a "v" key containing the version string.
Test Plan
Examine log output from tests.