Skip to content

Conversation

@algorandskiy
Copy link
Contributor

@algorandskiy algorandskiy commented Dec 13, 2021

Summary

  • commitRound is designed to be async op triggered by commitSyncer but tracker ops must be synchronized.
  • catchpoint tracker's postCommit might take too long but in fact does not need to be in sync with other trackers

Test Plan

Use existing tests

@codecov-commenter
Copy link

codecov-commenter commented Dec 13, 2021

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 47.57%. Comparing base (6330862) to head (fd35c4e).
Report is 2004 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3310      +/-   ##
==========================================
+ Coverage   47.54%   47.57%   +0.02%     
==========================================
  Files         369      369              
  Lines       59618    59620       +2     
==========================================
+ Hits        28347    28364      +17     
+ Misses      27969    27961       -8     
+ Partials     3302     3295       -7     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@algorandskiy algorandskiy marked this pull request as draft December 13, 2021 22:34
@algorandskiy algorandskiy changed the title No long-lasting locks in trackerRegistry.commitRound Exclude potentially long catchpoint generation from trackerRegistry lock Dec 13, 2021
@algorandskiy algorandskiy marked this pull request as ready for review December 13, 2021 23:22
@algorandskiy
Copy link
Contributor Author

Closed in pref of #3311

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants