Skip to content

testing: reword partitiontest lint message. #3297

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
tsachiherman merged 3 commits into from
Dec 15, 2021
Merged

testing: reword partitiontest lint message. #3297

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
061e614
Reword partitiontest lint message.
winder Dec 9, 2021
47efc1a
Fix parameterType/ParameterName
winder Dec 13, 2021
bb33dc4
Mention the comment case.
winder Dec 13, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion cmd/partitiontest_linter/linter.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,6 +28,7 @@ const functionName string = "PartitionTest"
const fileNameSuffix string = "_test.go"
const functionNamePrefix string = "Test"
const parameterType string = "T"
const parameterName string = "t"

// Analyzer initilization
var Analyzer = &analysis.Analyzer{
Expand Down Expand Up @@ -58,7 +59,7 @@ func run(pass *analysis.Pass) (interface{}, error) {
continue
}
if !isSearchLineInFunction(fn) {
pass.Reportf(fn.Pos(), "%s function is missing %s.%s(<%s type parameter>)", fn.Name.Name, packageName, functionName, parameterType)
pass.Reportf(fn.Pos(), "%s: Add missing partition call to top of test. To disable partitioning, add it as a comment: %s.%s(%s)", fn.Name.Name, packageName, functionName, parameterName)
}

}
Expand Down