Skip to content

TestEcdsa: fix flaky "tampering" of public key #3282

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
tsachiherman merged 4 commits into from
Dec 9, 2021
Merged

TestEcdsa: fix flaky "tampering" of public key #3282

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
c356aef
TestEcdsa: fix flaky "tampering" of public key
cce Dec 7, 2021
e35fa51
clarify byte overflow with comment
cce Dec 7, 2021
9d3def3
fix another tampered[0] = 0
cce Dec 7, 2021
710037e
fix ecdsa decompress pkTampered2 test case
cce Dec 8, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 7 additions & 6 deletions data/transactions/logic/evalCrypto_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -212,9 +212,9 @@ byte 0x%s
&&`
pkTampered1 := make([]byte, len(pk))
copy(pkTampered1, pk)
pkTampered1[0] = 0
pkTampered2 := make([]byte, len(pk))
copy(pkTampered2, pk[1:])
pkTampered1[0] = 0 // first byte is a prefix of either 0x02 or 0x03
pkTampered2 := make([]byte, len(pk)-1) // must be 33 bytes length
copy(pkTampered2, pk)
Comment on lines +216 to +217
Copy link
Contributor

@jasonpaulos jasonpaulos Dec 8, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: pkTampered2 := pk[:len(pk)-1] would achieve the same thing


var decompressTests = []struct {
key []byte
Expand All @@ -224,8 +224,9 @@ byte 0x%s
{pkTampered1, false},
{pkTampered2, false},
}
for _, test := range decompressTests {
for i, test := range decompressTests {
t.Run(fmt.Sprintf("decompress/pass=%v", test.pass), func(t *testing.T) {
t.Log("decompressTests i", i)
src := fmt.Sprintf(source, hex.EncodeToString(test.key), hex.EncodeToString(x), hex.EncodeToString(y))
if test.pass {
testAccepts(t, src, 5)
Expand Down Expand Up @@ -255,8 +256,8 @@ ecdsa_verify Secp256k1
v := int(sign[64])

rTampered := make([]byte, len(r))
copy(rTampered, pk)
rTampered[0] = 0
copy(rTampered, r)
rTampered[0] += byte(1) // intentional overflow

var verifyTests = []struct {
data string
Expand Down