Add compatibility mode for listpartkeys goal command. #3207
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
winder
commented
Nov 12, 2021
Comment on lines
+1069
to
+1113
| // legacyListParticipationKeysCommand prints key information in the same | ||
| // format as earlier versions of goal. Some users are using this information | ||
| // in scripts and need some extra time to migrate to the REST API. | ||
| func legacyListParticipationKeysCommand() { | ||
| dataDir := ensureSingleDataDir() | ||
|
|
||
| client := ensureGoalClient(dataDir, libgoal.DynamicClient) | ||
| parts, err := client.ListParticipationKeyFiles() | ||
| if err != nil { | ||
| reportErrorf(errorRequestFail, err) | ||
| } | ||
|
|
||
| var filenames []string | ||
| for fn := range parts { | ||
| filenames = append(filenames, fn) | ||
| } | ||
| sort.Strings(filenames) | ||
|
|
||
| rowFormat := "%-10s\t%-80s\t%-60s\t%12s\t%12s\t%12s\n" | ||
| fmt.Printf(rowFormat, "Registered", "Filename", "Parent address", "First round", "Last round", "First key") | ||
| for _, fn := range filenames { | ||
| onlineInfoStr := "unknown" | ||
| onlineAccountInfo, err := client.AccountInformation(parts[fn].Address().GetUserAddress()) | ||
| if err == nil { | ||
| votingBytes := parts[fn].Voting.OneTimeSignatureVerifier | ||
| vrfBytes := parts[fn].VRF.PK | ||
| if onlineAccountInfo.Participation != nil && | ||
| (string(onlineAccountInfo.Participation.ParticipationPK) == string(votingBytes[:])) && | ||
| (string(onlineAccountInfo.Participation.VRFPK) == string(vrfBytes[:])) && | ||
| (onlineAccountInfo.Participation.VoteFirst == uint64(parts[fn].FirstValid)) && | ||
| (onlineAccountInfo.Participation.VoteLast == uint64(parts[fn].LastValid)) && | ||
| (onlineAccountInfo.Participation.VoteKeyDilution == parts[fn].KeyDilution) { | ||
| onlineInfoStr = "yes" | ||
| } else { | ||
| onlineInfoStr = "no" | ||
| } | ||
| } | ||
| // it's okay to proceed without algod info | ||
| first, last := parts[fn].ValidInterval() | ||
| fmt.Printf(rowFormat, onlineInfoStr, fn, parts[fn].Address().GetUserAddress(), | ||
| fmt.Sprintf("%d", first), | ||
| fmt.Sprintf("%d", last), | ||
| fmt.Sprintf("%d.%d", parts[fn].Voting.FirstBatch, parts[fn].Voting.FirstOffset)) | ||
| } | ||
| } |
Contributor
Author
There was a problem hiding this comment.
The only difference between this function and the previous version of the cobra command is to rename ListParticipationKey to ListParticipationKeyFiles.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Add a simple compatibility mode to give a buffer for migration to new REST APIs.
Test Plan
Manual testing: