Add c5d.4xlarge and c5d.18xlarge us-east-2 to hosttemplates.json #3160
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
algobarb
requested review from
algojack,
bricerisingalgorand,
egieseke and
onetechnical
Codecov Report
@@ Coverage Diff @@
## master #3160 +/- ##
==========================================
- Coverage 43.78% 40.00% -3.79%
==========================================
Files 391 391
Lines 86880 86880
==========================================
- Hits 38038 34752 -3286
- Misses 42808 46516 +3708
+ Partials 6034 5612 -422
Continue to review full report at Codecov.
|
onetechnical
approved these changes
Oct 29, 2021
cce
pushed a commit
to cce/go-algorand
that referenced
this pull request
Nov 3, 2021
…orand#3160) Add c5d.4xlarge and c5d.18xlarge us-east-2 to hosttemplates.json so that our team can use them moving forward for performance tests. For performance testing, we've needed to add these to each codebase we're working with to use these machines. This is part of our effort to automate performance testing internally.
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Add c5d.4xlarge and c5d.18xlarge us-east-2 to hosttemplates.json so that our team can use them moving forward for performance tests.
For performance testing, we've needed to add these to each codebase we're working with to use these machines. This is part of our effort to automate performance testing internally.
Test Plan
This same hosttemplates.json has been used in our performance testing.