Skip to content

Conversation

@winder
Copy link
Contributor

@winder winder commented Oct 27, 2021

Summary

Allocate a spot in the key registry for state proofs. This is not used yet but should allow us to add them when we are ready.

Test Plan

Existing tests should detect any regression.

@winder winder requested a review from id-ms October 27, 2021 18:10
@winder winder self-assigned this Oct 27, 2021
@codecov-commenter
Copy link

codecov-commenter commented Oct 27, 2021

Codecov Report

Merging #3156 (d8dff86) into feature/partkey (25c8f26) will decrease coverage by 0.02%.
The diff coverage is 33.33%.

Impacted file tree graph

@@                 Coverage Diff                 @@
##           feature/partkey    #3156      +/-   ##
===================================================
- Coverage            44.12%   44.10%   -0.03%     
===================================================
  Files                  394      394              
  Lines                87601    87604       +3     
===================================================
- Hits                 38654    38635      -19     
- Misses               42855    42874      +19     
- Partials              6092     6095       +3     
Impacted Files Coverage Δ
data/account/participationRegistry.go 81.44% <33.33%> (-0.38%) ⬇️
agreement/cryptoVerifier.go 75.73% <0.00%> (-2.21%) ⬇️
agreement/proposalManager.go 96.07% <0.00%> (-1.97%) ⬇️
network/requestTracker.go 70.25% <0.00%> (-1.30%) ⬇️
catchup/service.go 69.32% <0.00%> (-1.25%) ⬇️
ledger/blockqueue.go 83.90% <0.00%> (-1.15%) ⬇️
data/abi/abi_type.go 92.03% <0.00%> (-1.00%) ⬇️
network/wsPeer.go 70.66% <0.00%> (-0.80%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 25c8f26...d8dff86. Read the comment docs.

key BLOB --* msgpack encoding of ParticipationAccount.BlockProof.SignatureAlgorithm
)`
*/
createStateProof = `CREATE TABLE StateProofKeys (
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we need to construct an index for the round (I.e we want to SELECT according to round)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

With the registry, we'll need to select on (pk, round), which is the primary key. Since that's the primary key we shouldn't need another index.

@winder winder requested review from id-ms and tsachiherman October 29, 2021 13:32
@winder winder merged commit 32efa83 into algorand:feature/partkey Oct 29, 2021
@winder winder deleted the will/state-proof-table branch October 29, 2021 14:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants