-
Notifications
You must be signed in to change notification settings - Fork 523
Add state proof table to key registry #3156
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add state proof table to key registry #3156
Conversation
Codecov Report
@@ Coverage Diff @@
## feature/partkey #3156 +/- ##
===================================================
- Coverage 44.12% 44.10% -0.03%
===================================================
Files 394 394
Lines 87601 87604 +3
===================================================
- Hits 38654 38635 -19
- Misses 42855 42874 +19
- Partials 6092 6095 +3
Continue to review full report at Codecov.
|
| key BLOB --* msgpack encoding of ParticipationAccount.BlockProof.SignatureAlgorithm | ||
| )` | ||
| */ | ||
| createStateProof = `CREATE TABLE StateProofKeys ( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we need to construct an index for the round (I.e we want to SELECT according to round)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
With the registry, we'll need to select on (pk, round), which is the primary key. Since that's the primary key we shouldn't need another index.
Summary
Allocate a spot in the key registry for state proofs. This is not used yet but should allow us to add them when we are ready.
Test Plan
Existing tests should detect any regression.