ledger: refactor ledger internal tests #3149
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #3149 +/- ##
==========================================
- Coverage 43.78% 39.90% -3.89%
==========================================
Files 391 391
Lines 86880 86880
==========================================
- Hits 38041 34667 -3374
- Misses 42806 46588 +3782
+ Partials 6033 5625 -408
Continue to review full report at Codecov.
|
tsachiherman
changed the title
jannotti
approved these changes
Oct 27, 2021
cce
pushed a commit
to cce/go-algorand
that referenced
this pull request
Nov 3, 2021
Summary Refactor internal ledger evaluator testing to use the real ledger instead of using a dummy ledger. In order to do this, I moved the related tests into an "internal_test" package. That allowed me to import both "ledger/internal" as well as "ledger", and conduct the test against a real ledger. Test Plan These are tests.
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Refactor internal ledger evaluator testing to use the real ledger instead of using a dummy ledger.
In order to do this, I moved the related tests into an "internal_test" package. That allowed me to import both "ledger/internal" as well as "ledger", and conduct the test against a real ledger.
Test Plan
These are tests.