Skip to content

catchup: ignore benign evaluator failures #3135

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
tsachiherman merged 3 commits into from
Oct 25, 2021
Merged

catchup: ignore benign evaluator failures #3135

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
a1dae96
Fix regression in TestReproducibleCatchpointLabels
tsachiherman Oct 11, 2021
806b252
Merge branch 'master' of github.com:tsachiherman/go-algorand
tsachiherman Oct 25, 2021
8d70326
safely ignore ErrNonSequentialBlockEval in catchup
tsachiherman Oct 25, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions catchup/service.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -349,6 +349,9 @@ func (s *Service) fetchAndWrite(r basics.Round, prevFetchCompleteChan chan bool,

if err != nil {
switch err.(type) {
case ledgercore.ErrNonSequentialBlockEval:
s.log.Infof("fetchAndWrite(%d): no need to re-evaluate historical block", r)
return true
case ledgercore.BlockInLedgerError:
s.log.Infof("fetchAndWrite(%d): block already in ledger", r)
return true
Expand Down