Skip to content

Conversation

@AlgoStephenAkiki
Copy link
Contributor

Resolves #3129

Summary

Test Plan

@AlgoStephenAkiki AlgoStephenAkiki marked this pull request as ready for review October 22, 2021 19:00
Copy link
Contributor

@winder winder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov-commenter
Copy link

Codecov Report

Merging #3130 (804a726) into master (17429d5) will increase coverage by 0.00%.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #3130   +/-   ##
=======================================
  Coverage   43.70%   43.70%           
=======================================
  Files         390      390           
  Lines       86689    86688    -1     
=======================================
+ Hits        37887    37889    +2     
+ Misses      42780    42777    -3     
  Partials     6022     6022           
Impacted Files Coverage Δ
daemon/algod/api/server/v2/handlers.go 0.00% <ø> (ø)
agreement/cryptoVerifier.go 75.73% <0.00%> (-2.21%) ⬇️
agreement/proposalManager.go 96.07% <0.00%> (-1.97%) ⬇️
catchup/service.go 69.59% <0.00%> (-0.76%) ⬇️
network/wsNetwork.go 64.50% <0.00%> (-0.20%) ⬇️
network/requestTracker.go 71.12% <0.00%> (+0.86%) ⬆️
data/abi/abi_type.go 93.03% <0.00%> (+0.99%) ⬆️
network/wsPeer.go 72.00% <0.00%> (+2.13%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 17429d5...804a726. Read the comment docs.

@tsachiherman tsachiherman merged commit 8ff58cb into algorand:master Nov 3, 2021
@egieseke egieseke mentioned this pull request Nov 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Remove Unnecessary Handler Code

4 participants