txnsync: implement missing bridge between txnsync and classic transaction messages #3102
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #3102 +/- ##
==========================================
- Coverage 43.70% 43.69% -0.01%
==========================================
Files 391 391
Lines 86830 86834 +4
==========================================
- Hits 37946 37941 -5
- Misses 42849 42859 +10
+ Partials 6035 6034 -1
Continue to review full report at Codecov.
|
brianolson
approved these changes
Oct 20, 2021
Contributor
brianolson
left a comment
brianolson
left a comment
There was a problem hiding this comment.
deceptively simple since all the parts were built
onetechnical
pushed a commit
that referenced
this pull request
Oct 20, 2021
…tion messages (#3102) Summary This PR adds the missing bridge between the txnsync and the classic transaction relaying: when a transaction message arrive and being added to the transaction pool, we need to attempt to relay these messages right away using the classic transaction messages. That would allow relays to be compatible with both 2.1 and 3.0 nodes. Test Plan e2e test was added.
tsachiherman
added a commit
to tsachiherman/go-algorand
that referenced
this pull request
Nov 2, 2021
… transaction messages (algorand#3102)" This reverts commit e853e2e.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds the missing bridge between the txnsync and the classic transaction relaying:
when a transaction message arrive and being added to the transaction pool, we need to attempt to
relay these messages right away using the classic transaction messages. That would allow relays to
be compatible with both 2.1 and 3.0 nodes.
Test Plan
e2e test was added.