.Register() complains only if the primary record fails #3091
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
opportunistic cache cleanup is best-effort
winder
suggested changes
Oct 19, 2021
Contributor
winder
left a comment
winder
left a comment
There was a problem hiding this comment.
Looks good just one request
| } | ||
|
|
||
| // Duplicate creates a copy of the current object. This is required once secrets are stored. | ||
| func (r ParticipationRecord) Duplicate() ParticipationRecord { |
Contributor
There was a problem hiding this comment.
Could you keep this? I'm going to need it soon.
This reverts commit 2ebba7c.
winder
approved these changes
Oct 19, 2021
winder
suggested changes
Oct 19, 2021
Contributor
winder
left a comment
winder
left a comment
There was a problem hiding this comment.
Actually, could you add a test? I think it should straight forward, just send an event with an optional key that doesn't exist.
winder
approved these changes
Oct 21, 2021
Contributor
winder
left a comment
winder
left a comment
There was a problem hiding this comment.
This just needs a test, I have one prepared and will add it in another PR.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
.Register() complains only if the primary record fails
opportunistic cache cleanup is best-effort
Test Plan
Passes existing tests.