-
Notifications
You must be signed in to change notification settings - Fork 523
Add ABI support to goal #3088
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add ABI support to goal #3088
Conversation
jasonpaulos
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking good, just a nit
| var methodAppCmd = &cobra.Command{ | ||
| Use: "method", | ||
| Short: "Invoke a method", | ||
| Long: `Invoke a method in an App (stateful contract) with an application call transaction`, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not proposing any changes here, but view this as a learning opportunity for me about Algorand's conventions. Cleary the convention in the file is for this field to use raw string literals. I guess that makes sense, because in theory the Long description could span several lines. However, none of the descriptions in this file seem to utilize any of the string literal's special features. Any thoughts? You can also totally ignore.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't have specific thoughts or idea about it, just following the previous conventions. I just noticed the nearest editing for adding method/updating description is 16 months ago... and I suppose they might want to do something with string literal.
Summary
methodsub-command to accept method signature and application argsAddressing #2803
Test Plan