Skip to content

Conversation

@jannotti
Copy link
Contributor

@jannotti jannotti commented Oct 18, 2021

byte "hi" "there" did not report an error, but should.
pushbytes was not consistent with bytes in reporting errors, but should be.

@jannotti jannotti self-assigned this Oct 18, 2021
@codecov-commenter
Copy link

codecov-commenter commented Oct 18, 2021

Codecov Report

Merging #3087 (f0e3cce) into master (b9c6032) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #3087   +/-   ##
=======================================
  Coverage   43.66%   43.66%           
=======================================
  Files         391      391           
  Lines       86855    86859    +4     
=======================================
+ Hits        37927    37931    +4     
- Misses      42895    42897    +2     
+ Partials     6033     6031    -2     
Impacted Files Coverage Δ
data/transactions/teal.go 84.00% <ø> (ø)
data/transactions/logic/assembler.go 79.32% <100.00%> (+0.05%) ⬆️
network/wsPeer.go 71.24% <0.00%> (-3.11%) ⬇️
ledger/blockqueue.go 81.03% <0.00%> (-1.15%) ⬇️
data/abi/abi_type.go 90.90% <0.00%> (-0.91%) ⬇️
catchup/service.go 70.12% <0.00%> (ø)
ledger/internal/eval.go 70.21% <0.00%> (+0.26%) ⬆️
crypto/merkletrie/node.go 93.48% <0.00%> (+1.86%) ⬆️
agreement/proposalManager.go 98.03% <0.00%> (+1.96%) ⬆️
crypto/merkletrie/trie.go 68.61% <0.00%> (+2.18%) ⬆️
... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b9c6032...f0e3cce. Read the comment docs.

Copy link
Contributor

@jasonpaulos jasonpaulos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@jannotti jannotti merged commit 78317e8 into algorand:master Oct 18, 2021
@jannotti jannotti deleted the byte-immediate-check branch October 18, 2021 16:55
@egieseke egieseke mentioned this pull request Nov 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants