ledger: remove duplicate testing of accounts totals #3053
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #3053 +/- ##
==========================================
- Coverage 43.68% 43.66% -0.03%
==========================================
Files 391 391
Lines 86870 86845 -25
==========================================
- Hits 37953 37918 -35
- Misses 42886 42895 +9
- Partials 6031 6032 +1
Continue to review full report at Codecov.
|
algorandskiy
previously approved these changes
Oct 14, 2021
algorandskiy
approved these changes
Oct 14, 2021
cce
pushed a commit
to cce/go-algorand
that referenced
this pull request
Oct 28, 2021
## Summary This PR eliminate the `totalsNewRounds`, which perform the exact same calculation previously performed by the block evaluator. ## Test Plan - [x] Unit tests updates. - [x] Catchpoint label testing : starting a node catching up to 16,800,000 and the correct catchpoint label was observed on round 16,810,000.
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR eliminate the
totalsNewRounds, which perform the exact same calculation previously performed by the block evaluator.Test Plan