Skip to content

Conversation

@tsachiherman
Copy link
Contributor

Summary

The e2e test TestPartitionHalfOffline was failing due to the deadlock detection failing while the old keys are being deleted.
This change would reduce the key dilution, and should shorten the duration it takes to generate a new batch.

Test Plan

This is a test.

@codecov-commenter
Copy link

codecov-commenter commented Oct 12, 2021

Codecov Report

Merging #3041 (c48661e) into master (a516544) will increase coverage by 0.00%.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #3041   +/-   ##
=======================================
  Coverage   43.65%   43.66%           
=======================================
  Files         391      391           
  Lines       86779    86779           
=======================================
+ Hits        37887    37889    +2     
+ Misses      42864    42863    -1     
+ Partials     6028     6027    -1     
Impacted Files Coverage Δ
ledger/blockqueue.go 82.18% <0.00%> (-1.73%) ⬇️
ledger/acctupdates.go 66.25% <0.00%> (-0.49%) ⬇️
catchup/service.go 70.12% <0.00%> (+0.77%) ⬆️
crypto/merkletrie/node.go 93.48% <0.00%> (+1.86%) ⬆️
crypto/merkletrie/trie.go 68.61% <0.00%> (+2.18%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a516544...c48661e. Read the comment docs.

@tsachiherman tsachiherman merged commit c4bbdf8 into algorand:master Oct 12, 2021
@tsachiherman tsachiherman deleted the tsachi/lighter_key_dilution_TestPartitionHalfOffline branch October 12, 2021 19:30
cce pushed a commit to cce/go-algorand that referenced this pull request Oct 28, 2021
…n values (algorand#3041)

## Summary

The e2e test `TestPartitionHalfOffline` was failing due to the deadlock detection failing while the old keys are being deleted.
This change would reduce the key dilution, and should shorten the duration it takes to generate a new batch.

## Test Plan

This is a test.
@egieseke egieseke mentioned this pull request Nov 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants