Adjust the application of dontReportFailures in syncTest #3018
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In testing.T, Error, Errorf, and Fail do not terminate the test. Error and Errorf call Fail. There will be another call to FailNow to terminate the test. (FailNow also calls Fail.) When dontReportFailures is set in Error, Errorf, and Fail, the test will not be terminated. Moreover, the subsequent call to FailNow will be ignored because of the set dontReportFailures flag. In this change, dontReportFailures will not be set for Error, Errorf, and Fail so that the subsequent FailNow will terminate the test.
Codecov Report
@@ Coverage Diff @@
## master #3018 +/- ##
==========================================
+ Coverage 43.84% 43.86% +0.01%
==========================================
Files 385 385
Lines 86329 86329
==========================================
+ Hits 37852 37865 +13
+ Misses 42515 42504 -11
+ Partials 5962 5960 -2
Continue to review full report at Codecov.
|
algonautshant
changed the title
cce
pushed a commit
to cce/go-algorand
that referenced
this pull request
Oct 28, 2021
In testing.T, Error, Errorf, and Fail do not terminate the test. Error and Errorf call Fail. There will be another call to FailNow to terminate the test. (FailNow also calls Fail.) When `dontReportFailures` is set in Error, Errorf, and Fail, the test will not be terminated. Moreover, the subsequent call to FailNow will be ignored because of the set dontReportFailures flag. In this change, dontReportFailures will not be set for Error, Errorf, and Fail so that the subsequent FailNow will terminate the test.
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
In testing.T, Error, Errorf, and Fail do not terminate the test.
Error and Errorf call Fail.
There will be another call to FailNow to terminate the test. (FailNow also calls Fail.)
When dontReportFailures is set in Error, Errorf, and Fail, the test will not be terminated.
Moreover, the subsequent call to FailNow will be ignored because of the set dontReportFailures flag.
In this change, dontReportFailures will not be set for Error, Errorf, and Fail so that the subsequent FailNow will terminate the test.
This issue is a fallout from #2844
Fixes #3020
Test Plan
This is a fix to the testing infrastructure.