Move accountdb schema migration to trackerdb.go #2984
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
algorandskiy
force-pushed
the
pavel/ledger-au-schema
branch
from
c0a69c7 to
9aa9c22
Compare
Codecov Report
@@ Coverage Diff @@
## master #2984 +/- ##
==========================================
+ Coverage 40.00% 40.01% +0.01%
==========================================
Files 383 384 +1
Lines 86736 86749 +13
==========================================
+ Hits 34699 34713 +14
- Misses 46425 46426 +1
+ Partials 5612 5610 -2
Continue to review full report at Codecov.
|
algorandskiy
force-pushed
the
pavel/ledger-au-schema
branch
from
9aa9c22 to
8129027
Compare
Contributor
Author
|
Not sure why it started the Branch build |
tsachiherman
reviewed
Oct 5, 2021
tsachiherman
reviewed
Oct 5, 2021
tsachiherman
suggested changes
Oct 5, 2021
Contributor
tsachiherman
left a comment
tsachiherman
left a comment
There was a problem hiding this comment.
please review error/info messages and update the method names; looks good otherwise.
algorandskiy
force-pushed
the
pavel/ledger-au-schema
branch
from
8129027 to
2d8f334
Compare
tsachiherman
approved these changes
Oct 8, 2021
tsachiherman
approved these changes
Oct 8, 2021
cce
pushed a commit
to cce/go-algorand
that referenced
this pull request
Oct 28, 2021
## Summary * Moved code from **acctupdates.go** to **trackerdb.go**. * Extracted db creation and init from`accountsInitialize` to `trackerDBInitialize` * `reloadLedger` now calls `trackerDBInitialize` right after block db init * `reloadLedger` also has post-creation actions like vacuuming Limitations: 1. Tables creation still calls `accountsInit` for initial tables creation and inserting genesis accounts. 2. Migration code still have some business logic. ## Test Plan Use existing test suite
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
accountsInitializetotrackerDBInitializereloadLedgernow callstrackerDBInitializeright after block db initreloadLedgeralso has post-creation actions like vacuumingLimitations:
accountsInitfor initial tables creation and inserting genesis accounts.Test Plan
Use existing test suite