Skip to content

Conversation

@jannotti
Copy link
Contributor

vFuture, LogicVersion changed to 6

Support RekeyTo field, and Keyreg transactions

vFuture, LogicVersion changed to 6

Support RekeyTo field, and Keyreg transactions
@codecov-commenter
Copy link

codecov-commenter commented Sep 30, 2021

Codecov Report

Merging #2974 (39cdf6d) into master (412aef5) will increase coverage by 0.00%.
The diff coverage is 54.68%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #2974   +/-   ##
=======================================
  Coverage   47.63%   47.63%           
=======================================
  Files         358      359    +1     
  Lines       57887    57923   +36     
=======================================
+ Hits        27573    27591   +18     
- Misses      27190    27213   +23     
+ Partials     3124     3119    -5     
Impacted Files Coverage Δ
data/transactions/logic/fields.go 81.57% <ø> (ø)
data/transactions/logic/opcodes.go 100.00% <ø> (ø)
ledger/apply/apply.go 0.00% <0.00%> (ø)
ledger/eval.go 78.03% <33.33%> (+<0.01%) ⬆️
data/transactions/logic/eval.go 85.42% <68.29%> (-0.28%) ⬇️
ledger/applications.go 58.11% <71.42%> (+0.08%) ⬆️
config/consensus.go 84.53% <100.00%> (+0.05%) ⬆️
agreement/cryptoVerifier.go 75.73% <0.00%> (-2.21%) ⬇️
agreement/proposalManager.go 96.07% <0.00%> (-1.97%) ⬇️
network/wsPeer.go 74.37% <0.00%> (-0.84%) ⬇️
... and 5 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 412aef5...39cdf6d. Read the comment docs.

func TestActionTypes(t *testing.T) {
func TestInnerTypesV5(t *testing.T) {
v5, _ := makeSampleEnvWithVersion(5)
// not alllowed in v5
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sp allowed

Copy link
Contributor

@jasonpaulos jasonpaulos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

eval.txn(t, pay.Noted("again"))
eval.txn(t, nonpart.Noted("again"), "cannot change online/offline")
l.endBlock(t, eval)
// Ppaid fee and 1. Did not get rewards
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sp paid

@jannotti jannotti merged commit f17f73e into algorand:master Oct 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants