go-algorand 3.0.1-stable

.golangci-warnings.yml

@@ -1,7 +1,7 @@
 run:
   timeout: 5m
   tests: true
-  
+
 linters:
   disable-all: true
   enable:
@@ -74,3 +74,6 @@ issues:
         - gosimple
         - unused
         - partitiontest
+    - path: crypto/secp256k1/secp256_test\.go
+      linters:
+        - partitiontest

.travis.yml

@@ -31,11 +31,6 @@ jobs:
         - scripts/travis/build_test.sh
 
     - stage: build_pr
-      os: linux
-      name: Ubuntu AMD64 CodeGen Verification
-      script:
-        - scripts/travis/codegen_verification.sh
-    - # same stage, parallel job
       os: linux
       name: Ubuntu AMD64 Build
       script:
@@ -92,11 +87,6 @@ jobs:
          - $mingw64 scripts/travis/build_test.sh
 
     - stage: build_release
-      os: linux
-      name: Ubuntu AMD64 CodeGen Verification
-      script:
-        - scripts/travis/codegen_verification.sh
-    - # same stage, parallel job
       os: linux
       name: Ubuntu AMD64 Build
       script:
@@ -217,9 +207,6 @@ before_cache:
    esac
    docker save -o $HOME/docker_cache/images.tar $(docker images -a -q)
 
-#after_success:
-#  - scripts/travis/upload_coverage.sh || true
-
 addons:
   apt:
     packages:

agreement/agreementtest/simulate_test.go

@@ -37,6 +37,7 @@ import (
 	"github.com/algorand/go-algorand/data/committee"
 	"github.com/algorand/go-algorand/logging"
 	"github.com/algorand/go-algorand/protocol"
+	"github.com/algorand/go-algorand/test/partitiontest"
 	"github.com/algorand/go-algorand/util/db"
 )
 
@@ -294,6 +295,8 @@ func (l *testLedger) EnsureDigest(c agreement.Certificate, verifier *agreement.A
 }
 
 func TestSimulate(t *testing.T) {
+	partitiontest.PartitionTest(t)
+
 	f, _ := os.Create(t.Name() + ".log")
 	logging.Base().SetJSONFormatter()
 	logging.Base().SetOutput(f)

agreement/fuzzer/tests_test.go

@@ -25,6 +25,7 @@ import (
 	"math"
 	"math/rand"
 	"os"
+
 	//ossignal "os/signal"
 	"path/filepath"
 	//"runtime/pprof"
@@ -36,6 +37,7 @@ import (
 
 	"github.com/algorand/go-algorand/logging"
 	"github.com/algorand/go-deadlock"
+
 	//"github.com/algorand/go-algorand/protocol"
 	"github.com/algorand/go-algorand/test/partitiontest"
 )
@@ -105,6 +107,8 @@ func testConfig(t *testing.T, config NetworkConfig) (network *Network) {
 */
 
 func TestCircularNetworkTopology(t *testing.T) {
+	// partitiontest.PartitionTest(t)
+	// Causes double partition, so commented out on purpose
 	var nodeCounts []int
 	if testing.Short() {
 		nodeCounts = []int{4, 6}
@@ -422,6 +426,8 @@ type FuzzerTestFile struct {
 }
 
 func TestFuzzer(t *testing.T) {
+	// partitiontest.PartitionTest(t)
+	// Causes double partition, so commented out on purpose
 	jsonFiles := make(map[string]string) // map json test to full json file name.
 	err := filepath.Walk(".", func(path string, info os.FileInfo, err error) error {
 		if strings.HasSuffix(info.Name(), ".json") {
@@ -475,6 +481,8 @@ func TestFuzzer(t *testing.T) {
 }
 
 func TestNetworkBandwidth(t *testing.T) {
+	// partitiontest.PartitionTest(t)
+	// Causes double partition, so commented out on purpose
 	// travis rans out of memory when we get a high nodes count.. so we'll skip it for now.
 	if testing.Short() {
 		t.Skip()

cmd/algofix/deadlock_test.go

@@ -25,6 +25,7 @@ import (
 	"strings"
 	"testing"
 
+	"github.com/algorand/go-algorand/test/partitiontest"
 	"github.com/stretchr/testify/require"
 )
 
@@ -130,6 +131,7 @@ func main() {
 `
 
 func TestDeadlockRewrite(t *testing.T) {
+	partitiontest.PartitionTest(t)
 	t.Run("simple", func(t *testing.T) { testDeadlock(t, deadlockSimpleSrc, deadlockSimpleDest) })
 	t.Run("onoff", func(t *testing.T) { testDeadlock(t, deadlockTestSrc, deadlockTestFin) })
 }

cmd/algofix/main_test.go

@@ -9,6 +9,8 @@ import (
 	"go/parser"
 	"strings"
 	"testing"
+
+	"github.com/algorand/go-algorand/test/partitiontest"
 )
 
 type testCase struct {
@@ -73,6 +75,7 @@ func parseFixPrint(t *testing.T, fn func(*ast.File) bool, desc, in string, mustB
 }
 
 func TestRewrite(t *testing.T) {
+	partitiontest.PartitionTest(t)
 	for _, tt := range testCases {
 		// Apply fix: should get tt.Out.
 		out, fixed, ok := parseFixPrint(t, tt.Fn, tt.Name, tt.In, true)

cmd/algoh/blockWatcher_test.go

@@ -23,6 +23,7 @@ import (
 	"time"
 
 	"github.com/algorand/go-algorand/daemon/algod/api/spec/v1"
+	"github.com/algorand/go-algorand/test/partitiontest"
 	"github.com/stretchr/testify/require"
 )
 
@@ -38,6 +39,7 @@ func bw(client Client) *blockWatcher {
 // When the status continues to report block 300
 // Then blockIfStalled will block until the next block is reported
 func TestBlockIfStalled(t *testing.T) {
+	partitiontest.PartitionTest(t)
 	client := mockClient{
 		error:   []error{nil, nil, nil},
 		status:  makeNodeStatuses(300, 300, 300, 301),
@@ -59,6 +61,7 @@ func TestBlockIfStalled(t *testing.T) {
 // When the status continues to increase quickly
 // Then blockIfCatchup will block until a block is reported twice
 func TestBlockIfCatchup(t *testing.T) {
+	partitiontest.PartitionTest(t)
 	client := mockClient{
 		error:   []error{nil, nil, nil},
 		status:  makeNodeStatuses(301, 302, 303, 304, 305, 306, 307, 308, 309, 310, 310),
@@ -80,6 +83,7 @@ func TestBlockIfCatchup(t *testing.T) {
 // When the status is not changing quickly
 // Then blockIfCatchup will return after the first status call.
 func TestBlockIfCaughtUp(t *testing.T) {
+	partitiontest.PartitionTest(t)
 	client := mockClient{
 		error:   []error{nil, nil, nil},
 		status:  makeNodeStatuses(300),
@@ -111,6 +115,7 @@ func (l *testlistener) onBlock(block v1.Block) {
 }
 
 func TestE2E(t *testing.T) {
+	partitiontest.PartitionTest(t)
 	client := makeMockClient(
 		[]error{nil, nil, nil},
 		makeNodeStatuses(300, 301, 302, 302, 302, 302, 302, 302, 310, 320, 321, 321, 321, 322),
@@ -159,6 +164,7 @@ func TestE2E(t *testing.T) {
 }
 
 func TestAbortDuringStall(t *testing.T) {
+	partitiontest.PartitionTest(t)
 	client := makeMockClient(
 		[]error{},
 		makeNodeStatuses(300),

cmd/algoh/blockstats_test.go

@@ -22,6 +22,7 @@ import (
 
 	"github.com/algorand/go-algorand/daemon/algod/api/spec/v1"
 	"github.com/algorand/go-algorand/logging/telemetryspec"
+	"github.com/algorand/go-algorand/test/partitiontest"
 	"github.com/stretchr/testify/require"
 )
 
@@ -42,6 +43,7 @@ func (mes *MockEventSender) EventWithDetails(category telemetryspec.Category, id
 }
 
 func TestConsecutiveBlocks(t *testing.T) {
+	partitiontest.PartitionTest(t)
 	sender := MockEventSender{}
 	bs := blockstats{log: &sender}
 
@@ -57,6 +59,7 @@ func TestConsecutiveBlocks(t *testing.T) {
 }
 
 func TestAgreementTime(t *testing.T) {
+	partitiontest.PartitionTest(t)
 	sleepTime := 50 * time.Millisecond
 	testAttempts := 0
 	const maxTestAttempts = 10

cmd/algoh/main.go

@@ -165,7 +165,7 @@ func main() {
 	}()
 
 	// Handle signals cleanly
-	c := make(chan os.Signal)
+	c := make(chan os.Signal, 1)
 	signal.Notify(c, os.Interrupt, syscall.SIGTERM, syscall.SIGINT)
 	signal.Ignore(syscall.SIGHUP)
 	go func() {

cmd/catchupsrv/download_test.go

@@ -17,25 +17,30 @@
 package main
 
 import (
-	"github.com/stretchr/testify/require"
 	"testing"
+
+	"github.com/algorand/go-algorand/test/partitiontest"
+	"github.com/stretchr/testify/require"
 )
 
 func TestBlockToPath(t *testing.T) {
+	partitiontest.PartitionTest(t)
 	require.Equal(t, "00/00/000000", blockToPath(0))
 	require.Equal(t, "00/00/0000rs", blockToPath(1000))
 	require.Equal(t, "05/yc/05ycfo", blockToPath(10000500))
 	require.Equal(t, "4ll/2c/4ll2cic", blockToPath(10012300500))
 }
 
 func TestBlockToFileName(t *testing.T) {
+	partitiontest.PartitionTest(t)
 	require.Equal(t, "000000", blockToFileName(0))
 	require.Equal(t, "0000rs", blockToFileName(1000))
 	require.Equal(t, "05ycfo", blockToFileName(10000500))
 	require.Equal(t, "4ll2cic", blockToFileName(10012300500))
 }
 
 func TestBlockToString(t *testing.T) {
+	partitiontest.PartitionTest(t)
 	require.Equal(t, "0", blockToString(0))
 	require.Equal(t, "rs", blockToString(1000))
 	require.Equal(t, "5ycfo", blockToString(10000500))