Add application account into a dryrun req created by goal #2945
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #2945 +/- ##
==========================================
+ Coverage 47.32% 47.33% +0.01%
==========================================
Files 355 355
Lines 57230 57219 -11
==========================================
+ Hits 27084 27085 +1
+ Misses 27088 27071 -17
- Partials 3058 3063 +5
Continue to review full report at Codecov.
|
jasonpaulos
reviewed
Sep 24, 2021
Contributor
jasonpaulos
left a comment
jasonpaulos
left a comment
There was a problem hiding this comment.
Mostly looks good, but I have some comments.
| accounts = append(accounts, otherAccts...) | ||
|
|
||
| apps := []basics.AppIndex{tx.ApplicationID} | ||
| apps = append(apps, tx.ForeignApps...) |
Contributor
There was a problem hiding this comment.
Not directly relevant to this change, but should this code also collect all foreign assets and look up the account balances of their creator to add to dr.Accounts?
Contributor
Author
There was a problem hiding this comment.
I'll add this in a separate PR
JasonWeathersby
approved these changes
Sep 24, 2021
jasonpaulos
approved these changes
Sep 24, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
goal clerkneeds to consider this account when creates dryrun request object--dryrun-accountsfor adding accounts that were rekeyed to an app account (or any other accounts).Test Plan
Tested manually. I'll add example from Jason W into sub-e2e tests in subseq PRs (need inner txns for indexer as well)